Skip to content
OpenAdvisories
Medium · 5.3 CVE-2023-28631 EUVD-2023-0886GHSA-5r3x-p7xx-x6q5

Attacker controlled data in AST nodes is not validated in comrak

Published Mar 28, 2023 · Updated Feb 18, 2025 · Assigned by GitHub_M

Description

comrak is a CommonMark + GFM compatible Markdown parser and renderer written in rust. A Comrak AST can be constructed manually by a program instead of parsing a Markdown document with `parse_document`. This AST can then be converted to HTML via `html::format_document_with_plugins`. However, the HTML formatting code assumes that the AST is well-formed. For example, many AST notes contain `[u8]` fields which the formatting code assumes is valid UTF-8 data. Several bugs can be triggered if this is not the case. Version 0.17.0 contains adjustments to the AST, storing strings instead of unvalidated byte arrays. Users are advised to upgrade. Users unable to upgrade may manually validate UTF-8 correctness of all data when assigning to `&[u8]` and `Vec<u8>` fields in the AST. This issue is also tracked as `GHSL-2023-049`.

Affected products

VendorProductAffectedFixed
kivikakk comrak < 0.17.0 —

Affected packages

EcosystemPackageAffectedFixedRecord
crates.io comrak < 0.17.0 0.17.0 GHSA-5r3x-p7xx-x6q5

References