Skip to content
OpenAdvisories
Unscored CVE-2023-52894 EUVD-2023-59605GHSA-9r79-4jhv-2rfr

usb: gadget: f_ncm: fix potential NULL ptr deref in ncm_bitrate()

Published Aug 21, 2024 · Updated May 11, 2026 · Assigned by Linux

Vendor: Linux Product: Linux Package: linux Package: linux Package: linux-allwinner-5.19 Package: linux-aws Package: linux-aws-5.0 Package: linux-aws-5.11 Package: linux-aws-5.13 Package: linux-aws-5.15 Package: linux-aws-5.19 Package: linux-aws-5.3 Package: linux-aws-5.4 Package: linux-aws-5.8 Package: linux-aws-6.2 Package: linux-aws-6.5 Package: linux-aws-fips Package: linux-aws-hwe Package: linux-azure Package: linux-azure-4.15 Package: linux-azure-5.11 Package: linux-azure-5.13 Package: linux-azure-5.15 Package: linux-azure-5.19 Package: linux-azure-5.3 Package: linux-azure-5.4 Package: linux-azure-5.8 Package: linux-azure-6.2 Package: linux-azure-6.5 Package: linux-azure-edge Package: linux-azure-fde Package: linux-azure-fde-5.19 Package: linux-azure-fde-6.2 Package: linux-azure-fips Package: linux-bluefield Package: linux-fips Package: linux-gcp Package: linux-gcp-4.15 Package: linux-gcp-5.11 Package: linux-gcp-5.13 Package: linux-gcp-5.15 Package: linux-gcp-5.19 Package: linux-gcp-5.3 Package: linux-gcp-5.4 Package: linux-gcp-5.8 Package: linux-gcp-6.2 Package: linux-gcp-6.5 Package: linux-gcp-fips Package: linux-gke Package: linux-gke-4.15 Package: linux-gke-5.15 Package: linux-gke-5.4 Package: linux-gkeop Package: linux-gkeop-5.15 Package: linux-gkeop-5.4 Package: linux-hwe Package: linux-hwe-5.11 Package: linux-hwe-5.13 Package: linux-hwe-5.15 Package: linux-hwe-5.19 Package: linux-hwe-5.4 Package: linux-hwe-5.8 Package: linux-hwe-6.2 Package: linux-hwe-6.5 Package: linux-hwe-edge Package: linux-ibm Package: linux-ibm-5.4 Package: linux-intel-5.13 Package: linux-intel-iot-realtime Package: linux-intel-iotg Package: linux-intel-iotg-5.15 Package: linux-iot Package: linux-kvm Package: linux-lowlatency Package: linux-lowlatency-hwe-5.15 Package: linux-lowlatency-hwe-5.19 Package: linux-lowlatency-hwe-6.2 Package: linux-lowlatency-hwe-6.5 Package: linux-nvidia Package: linux-nvidia-6.2 Package: linux-nvidia-tegra-5.15 Package: linux-oem Package: linux-oem-5.10 Package: linux-oem-5.13 Package: linux-oem-5.14 Package: linux-oem-5.17 Package: linux-oem-5.6 Package: linux-oem-6.0 Package: linux-oem-6.1 Package: linux-oem-6.5 Package: linux-oracle Package: linux-oracle-5.0 Package: linux-oracle-5.11 Package: linux-oracle-5.13 Package: linux-oracle-5.15 Package: linux-oracle-5.3 Package: linux-oracle-5.4 Package: linux-oracle-5.8 Package: linux-oracle-6.5 Package: linux-raspi Package: linux-raspi-5.4 Package: linux-raspi-realtime Package: linux-raspi2 Package: linux-realtime Package: linux-riscv Package: linux-riscv-5.11 Package: linux-riscv-5.15 Package: linux-riscv-5.19 Package: linux-riscv-5.8 Package: linux-riscv-6.5 Package: linux-starfive-5.19 Package: linux-starfive-6.2 Package: linux-starfive-6.5 Package: linux-vmware Package: linux-xilinx-zynqmp Platform: Linux Ecosystem: Debian Ecosystem: Ubuntu

Description

In the Linux kernel, the following vulnerability has been resolved:

usb: gadget: f_ncm: fix potential NULL ptr deref in ncm_bitrate()

In Google internal bug 265639009 we've received an (as yet) unreproducible
crash report from an aarch64 GKI 5.10.149-android13 running device.

AFAICT the source code is at:
https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2022-12-05_13-5.10

The call stack is:
ncm_close() -> ncm_notify() -> ncm_do_notify()
with the crash at:
ncm_do_notify+0x98/0x270
Code: 79000d0b b9000a6c f940012a f9400269 (b9405d4b)

Which I believe disassembles to (I don't know ARM assembly, but it looks sane enough to me...):

// halfword (16-bit) store presumably to event->wLength (at offset 6 of struct usb_cdc_notification)
0B 0D 00 79 strh w11, [x8, #6]

// word (32-bit) store presumably to req->Length (at offset 8 of struct usb_request)
6C 0A 00 B9 str w12, [x19, #8]

// x10 (NULL) was read here from offset 0 of valid pointer x9
// IMHO we're reading 'cdev->gadget' and getting NULL
// gadget is indeed at offset 0 of struct usb_composite_dev
2A 01 40 F9 ldr x10, [x9]

// loading req->buf pointer, which is at offset 0 of struct usb_request
69 02 40 F9 ldr x9, [x19]

// x10 is null, crash, appears to be attempt to read cdev->gadget->max_speed
4B 5D 40 B9 ldr w11, [x10, #0x5c]

which seems to line up with ncm_do_notify() case NCM_NOTIFY_SPEED code fragment:

event->wLength = cpu_to_le16(8);
req->length = NCM_STATUS_BYTECOUNT;

/* SPEED_CHANGE data is up/down speeds in bits/sec */
data = req->buf + sizeof *event;
data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));

My analysis of registers and NULL ptr deref crash offset
(Unable to handle kernel NULL pointer dereference at virtual address 000000000000005c)
heavily suggests that the crash is due to 'cdev->gadget' being NULL when executing:
data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
which calls:
ncm_bitrate(NULL)
which then calls:
gadget_is_superspeed(NULL)
which reads
((struct usb_gadget *)NULL)->max_speed
and hits a panic.

AFAICT, if I'm counting right, the offset of max_speed is indeed 0x5C.
(remember there's a GKI KABI reservation of 16 bytes in struct work_struct)

It's not at all clear to me how this is all supposed to work...
but returning 0 seems much better than panic-ing...

Affected products

VendorProductAffectedFixed
Linux Linux 4.9 4.14.304

Fixed in Linux distributions

Distributions backport fixes, so the version that fixes this vulnerability differs per release — upgrade to at least the version shown. From the distributions' security trackers and advisories.

ReleasePackageFixed inAdvisory
Debian 14 linux 6.1.8-1 —
Debian 13 linux 6.1.8-1 —
Debian 12 linux 6.1.8-1 —
ReleasePackageFixed inAdvisory
Ubuntu Nvidia-BlueField 22.04 LTS linux-bluefield 5.15.0-1015.17 —
Ubuntu 24.04 LTS linux-raspi-realtime No fix yet —
Ubuntu 22.04 LTS linux +1 5.15.0-70.77 —
Ubuntu 22.04 LTS linux-aws 5.15.0-1034.38 —
Ubuntu 22.04 LTS linux-azure 5.15.0-1036.43 —
Ubuntu 22.04 LTS linux-azure-fde 5.15.0-1036.43.1 —
Ubuntu 22.04 LTS linux-gcp 5.15.0-1032.40 —
Ubuntu 22.04 LTS linux-gke +1 5.15.0-1031.36 —
Ubuntu 22.04 LTS linux-gkeop 5.15.0-1018.23 —
Ubuntu 22.04 LTS linux-ibm 5.15.0-1028.31 —
Ubuntu 22.04 LTS linux-intel-iotg 5.15.0-1028.33 —
Ubuntu 22.04 LTS linux-nvidia 5.15.0-1023.23 —
Ubuntu 22.04 LTS linux-oracle 5.15.0-1033.39 —
Ubuntu 22.04 LTS linux-raspi 5.15.0-1027.29 —
Ubuntu 22.04 LTS linux-riscv +30 No fix yet —
Ubuntu 20.04 LTS linux 5.4.0-147.164 —
Ubuntu 20.04 LTS linux-aws 5.4.0-1100.108 —
Ubuntu 20.04 LTS linux-aws-5.15 5.15.0-1034.38~20.04.1 —
Ubuntu 20.04 LTS linux-azure 5.4.0-1106.112 —
Ubuntu 20.04 LTS linux-azure-5.15 5.15.0-1036.43~20.04.1 —
Ubuntu 20.04 LTS linux-bluefield 5.4.0-1062.68 —
Ubuntu 20.04 LTS linux-gcp 5.4.0-1103.112 —
Ubuntu 20.04 LTS linux-gcp-5.15 5.15.0-1032.40~20.04.1 —
Ubuntu 20.04 LTS linux-gke +26 No fix yet —
Ubuntu 20.04 LTS linux-gkeop 5.4.0-1067.71 —
Ubuntu 20.04 LTS linux-gkeop-5.15 5.15.0-1018.23~20.04.1 —
Ubuntu 20.04 LTS linux-hwe-5.15 +1 5.15.0-70.77~20.04.1 —
Ubuntu 20.04 LTS linux-ibm 5.4.0-1047.52 —
Ubuntu 20.04 LTS linux-intel-iotg-5.15 5.15.0-1030.35~20.04.1 —
Ubuntu 20.04 LTS linux-iot 5.4.0-1017.18 —
Ubuntu 20.04 LTS linux-kvm 5.4.0-1089.95 —
Ubuntu 20.04 LTS linux-nvidia-tegra-5.15 5.15.0-1014.14~20.04.1 —
Ubuntu 20.04 LTS linux-oracle 5.4.0-1099.108 —
Ubuntu 20.04 LTS linux-oracle-5.15 5.15.0-1033.39~20.04.1 —
Ubuntu 20.04 LTS linux-raspi 5.4.0-1083.94 —
Ubuntu 20.04 LTS linux-riscv-5.15 5.15.0-1031.35~20.04.1 —
Ubuntu 20.04 LTS linux-xilinx-zynqmp 5.4.0-1024.28 —
Ubuntu 18.04 LTS linux 4.15.0-209.220 —
Ubuntu 18.04 LTS linux-aws 4.15.0-1154.167 —
Ubuntu 18.04 LTS linux-aws-5.4 5.4.0-1100.108~18.04.1 —
Ubuntu 18.04 LTS linux-azure-4.15 4.15.0-1163.178 —
Ubuntu 18.04 LTS linux-azure-5.4 5.4.0-1106.112~18.04.1 —
Ubuntu 18.04 LTS linux-gcp +14 No fix yet —
Ubuntu 18.04 LTS linux-gcp-4.15 4.15.0-1148.164 —
Ubuntu 18.04 LTS linux-gcp-5.4 5.4.0-1103.112~18.04.1 —
Ubuntu 18.04 LTS linux-hwe-5.4 5.4.0-147.164~18.04.1 —
Ubuntu 18.04 LTS linux-ibm-5.4 5.4.0-1047.52~18.04.1 —
Ubuntu 18.04 LTS linux-kvm 4.15.0-1138.143 —
Ubuntu 18.04 LTS linux-oracle 4.15.0-1117.128 —
Ubuntu 18.04 LTS linux-oracle-5.4 5.4.0-1099.108~18.04.1 —
Ubuntu 18.04 LTS linux-raspi-5.4 5.4.0-1083.94~18.04.1 —
Show 8 more (older releases, extended support, other products)
ReleasePackageFixed inAdvisory
Ubuntu 16.04 LTS linux-hwe-edge No fix yet —
Ubuntu Pro Realtime 22.04 LTS linux-intel-iot-realtime 5.15.0-1024.29 —
Ubuntu Pro Realtime 22.04 LTS linux-realtime 5.15.0-1036.39 —
Ubuntu Pro FIPS 20.04 LTS linux-fips +3 No fix yet —
Ubuntu Pro FIPS 18.04 LTS linux-fips +3 No fix yet —
Ubuntu Pro FIPS-updates 20.04 LTS linux-aws-fips 5.4.0-1100.108+fips1 —
Ubuntu Pro FIPS-updates 20.04 LTS linux-azure-fips 5.4.0-1106.112+fips1 —
Ubuntu Pro FIPS-updates 20.04 LTS linux-fips 5.4.0-1075.84 —
Ubuntu Pro FIPS-updates 20.04 LTS linux-gcp-fips 5.4.0-1103.112+fips1 —
Ubuntu Pro FIPS-updates 18.04 LTS linux-aws-fips 4.15.0-2093.99 —
Ubuntu Pro FIPS-updates 18.04 LTS linux-azure-fips 4.15.0-2072.78 —
Ubuntu Pro FIPS-updates 18.04 LTS linux-fips 4.15.0-1109.120 —
Ubuntu Pro FIPS-updates 18.04 LTS linux-gcp-fips 4.15.0-2056.61 —
Ubuntu Pro 16.04 LTS linux-aws-hwe 4.15.0-1154.167~16.04.1 —
Ubuntu Pro 16.04 LTS linux-azure 4.15.0-1163.178~16.04.1 —
Ubuntu Pro 16.04 LTS linux-gcp 4.15.0-1148.164~16.04.1 —
Ubuntu Pro 16.04 LTS linux-hwe 4.15.0-209.220~16.04.1 —
Ubuntu Pro 16.04 LTS linux-oracle 4.15.0-1117.128~16.04.1 —
Ubuntu Pro 14.04 LTS linux-azure 4.15.0-1163.178~14.04.1 —
ReleasePackageFixed inAdvisory
SLES 15 SP5 kernel-64kb +4 5.14.21-150500.55.80.2 SUSE-SU-2024:3483-1
SLES 15 SP5 kernel-azure +2 5.14.21-150500.33.66.1 SUSE-SU-2024:3190-1
SLES 15 SP5 kernel-default-base 5.14.21-150500.55.80.2.150500.6.35.6 SUSE-SU-2024:3483-1
SLES 15 SP5 kernel-syms +1 5.14.21-150500.55.80.1 SUSE-SU-2024:3483-1
SLES 15 SP4 kernel-64kb +4 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLES 15 SP4 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SLES 15 SP4 kernel-docs +1 5.14.21-150400.24.133.1 SUSE-SU-2024:3408-1
Show 10 more (older releases, extended support, other products)
ReleasePackageFixed inAdvisory
SLES for SAP 15 SP4 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SLES for SAP 15 SP4 kernel-docs +1 5.14.21-150400.24.133.1 SUSE-SU-2024:3408-1
SLES for SAP 15 SP4 kernel-source +2 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLE Micro 5.5 kernel-default 5.14.21-150500.55.80.2 SUSE-SU-2024:3483-1
SLE Micro 5.5 kernel-default-base 5.14.21-150500.55.80.2.150500.6.35.6 SUSE-SU-2024:3483-1
SLE Micro 5.5 kernel-rt +1 5.14.21-150500.13.67.3 SUSE-SU-2024:3209-1
SLE Micro 5.4 kernel-default 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLE Micro 5.4 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SLE Micro 5.4 kernel-rt +1 5.14.21-150400.15.91.3 SUSE-SU-2024:3227-1
SLE Micro 5.3 kernel-default 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLE Micro 5.3 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SLE Micro 5.3 kernel-rt +1 5.14.21-150400.15.91.3 SUSE-SU-2024:3227-1
SLE Live Patching 15 SP5 kernel-default 5.14.21-150500.55.80.2 SUSE-SU-2024:3483-1
SLE Live Patching 15 SP5 kernel-livepatch-SLE15-SP5_Update_19 +1 1-150500.11.3.2 SUSE-SU-2024:3483-1, SUSE-SU-2024:3209-1
SLE Live Patching 15 SP4 kernel-default 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLE Live Patching 15 SP4 kernel-livepatch-SLE15-SP4_Update_31 1-150400.9.3.2 SUSE-SU-2024:3408-1
SLE HPC 15 SP4 kernel-64kb +3 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SLE HPC 15 SP4 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SLE HPC 15 SP4 kernel-docs +1 5.14.21-150400.24.133.1 SUSE-SU-2024:3408-1
SUSE Real Time Module 15 SP5 kernel-rt +2 5.14.21-150500.13.67.3 SUSE-SU-2024:3209-1
SUSE Real Time Module 15 SP5 kernel-syms-rt 5.14.21-150500.13.67.1 SUSE-SU-2024:3209-1
SUSE Manager Server 4.3 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SUSE Manager Server 4.3 kernel-source +2 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SUSE Manager Server 4.3 kernel-syms 5.14.21-150400.24.133.1 SUSE-SU-2024:3408-1
SUSE Manager Proxy 4.3 kernel-default-base 5.14.21-150400.24.133.2.150400.24.64.5 SUSE-SU-2024:3408-1
SUSE Manager Proxy 4.3 kernel-source +1 5.14.21-150400.24.133.2 SUSE-SU-2024:3408-1
SUSE Manager Proxy 4.3 kernel-syms 5.14.21-150400.24.133.1 SUSE-SU-2024:3408-1
ReleasePackageFixed inAdvisory
openSUSE Leap 15.5 dtb-aarch64 +3 5.14.21-150500.55.80.1 SUSE-SU-2024:3483-1
openSUSE Leap 15.5 kernel-64kb +6 5.14.21-150500.55.80.2 SUSE-SU-2024:3483-1
openSUSE Leap 15.5 kernel-azure +2 5.14.21-150500.33.66.1 SUSE-SU-2024:3190-1
openSUSE Leap 15.5 kernel-default-base 5.14.21-150500.55.80.2.150500.6.35.6 SUSE-SU-2024:3483-1
openSUSE Leap 15.5 kernel-rt +2 5.14.21-150500.13.67.3 SUSE-SU-2024:3209-1
openSUSE Leap 15.5 kernel-syms-rt 5.14.21-150500.13.67.1 SUSE-SU-2024:3209-1
Show 1 more (older releases, extended support, other products)
ReleasePackageFixed inAdvisory
openSUSE Leap Micro 5.5 kernel-default 5.14.21-150500.55.80.2 SUSE-SU-2024:3483-1
openSUSE Leap Micro 5.5 kernel-default-base 5.14.21-150500.55.80.2.150500.6.35.6 SUSE-SU-2024:3483-1
openSUSE Leap Micro 5.5 kernel-rt 5.14.21-150500.13.67.3 SUSE-SU-2024:3209-1

Advisories 6

References