Skip to content
OpenAdvisories
High · 8.2 CVE-2024-52811 EUVD-2024-46056

Acks not validated before logged to qlog leads to buffer overflow in ngtcp2

Published Nov 25, 2024 · Updated Nov 25, 2024 · Assigned by GitHub_M

Description

The ngtcp2 project is an effort to implement IETF QUIC protocol in C. In affected versions acks are not validated before being written to the qlog leading to a buffer overflow. In `ngtcp2_conn::conn_recv_pkt` for an ACK, there was new logic that got added to skip `conn_recv_ack` if an ack has already been processed in the payload. However, this causes us to also skip `ngtcp2_pkt_validate_ack`. The ack which was skipped still got written to qlog. The bug occurs in `ngtcp2_qlog::write_ack_frame`. It is now possible to reach this code with an invalid ack, suppose `largest_ack=0` and `first_ack_range=15`. Subtracting `largest_ack - first_ack_range` will lead to an integer underflow which is 20 chars long. However, the ngtcp2 qlog code assumes the number written is a signed integer and only accounts for 19 characters of overhead (see `NGTCP2_QLOG_ACK_FRAME_RANGE_OVERHEAD`). Therefore, we overwrite the buffer causing a heap overflow. This is high priority and could potentially impact many users if they enable qlog. qlog is disabled by default. Due to its overhead, it is most likely used for debugging purpose, but the actual use is unknown. ngtcp2 v1.9.1 fixes the bug and users are advised to upgrade. Users unable to upgrade should not turn on qlog.

Affected products

VendorProductAffectedFixed
ngtcp2 ngtcp2 = 1.9.0 —

Fixed in Linux distributions

Distributions backport fixes, so the version that fixes this vulnerability differs per release — upgrade to at least the version shown. From the distributions' security trackers and advisories.

ReleasePackageFixed inAdvisory
Ubuntu 26.10 ngtcp2 No fix yet —
Ubuntu 26.04 LTS ngtcp2 No fix yet —
Ubuntu 25.10 ngtcp2 No fix yet —
Ubuntu 24.04 LTS ngtcp2 No fix yet —
Show 1 more (older releases, extended support, other products)
ReleasePackageFixed inAdvisory
Ubuntu Pro 22.04 LTS ngtcp2 No fix yet —
ReleasePackageFixed inAdvisory
openSUSE Tumbleweed ngtcp2 1.10.0-1.1 openSUSE-SU-2025:14766-1

Advisories 1

References