Description
SiYuan versions before 3.8.4 fail to escape bookmark labels imported from notebook files when rendering them in the dock tree. Attackers can craft malicious .sy notebook files with unescaped HTML in bookmark attributes that execute scripts in the Electron renderer with access to child_process for command execution.
Affected products
| Vendor | Product | Affected | Fixed |
|---|---|---|---|
| siyuan-note | siyuan | < 3.8.4 | 3.8.4 |
References
- Patch Commit patch
- https://github.com/siyuan-note/siyuan product
- GitHub Security Advisory (GHSA-jhfc-9mcq-8p8v) vendor-advisory
- https://github.com/siyuan-note/siyuan/blob/v3.8.3/app/src/util/Tree.ts#L134 technical-description
- VulnCheck Advisory: SiYuan before 3.8.4 Cross-Site Scripting via Bookmark Labels third-party-advisory