Description
### Impact
Transactions were NOT committed despite the explicit `options.WithCommit` flag using table service client. Because of this, clients did not commit changes to the transaction, relying on the fact that the transaction commit was successful. This led (in rare cases) to a loss of data consistency.
### Patches
`ydb-go-sdk` contains this problem in versions from [v3.104.6](https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.104.6) to [v3.134.1](https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.134.1). The fix for this problem has been released in version [v3.134.2](https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.134.2) (https://github.com/ydb-platform/ydb-go-sdk/pull/2091).
### Workarounds
1) Use explicit `table.Transaction.CommitTx(ctx)` instead use `options.WithCommit()`.
2) Use transaction retrier `db.Table().DoTx(ctx, lambda)` instead explicit start transaction on session.
3) Use query client `db.Query().Do(ctx, lambda)` with the same logic in `lambda`
### Resources
Commit with bug https://github.com/ydb-platform/ydb-go-sdk/commit/251128a64763555d9a79ee7a131dd154c9000eb9
Commit with fix https://github.com/ydb-platform/ydb-go-sdk/commit/25dcff4c41153f1f9413512ba12999b40bf7154d
Affected packages
| Ecosystem | Package | Affected | Fixed | Record |
|---|---|---|---|---|
| Go | github.com/ydb-platform/ydb-go-sdk/v3 | >= 3.104.6, < 3.134.2 | 3.134.2 | GHSA-28xx-pppm-vqff |
References
- https://github.com/ydb-platform/ydb-go-sdk/security/advisories/GHSA-28xx-pppm-vqff web
- https://github.com/ydb-platform/ydb-go-sdk/pull/2091 web
- https://github.com/ydb-platform/ydb-go-sdk/commit/251128a64763555d9a79ee7a131dd154c9000eb9 web
- https://github.com/ydb-platform/ydb-go-sdk/commit/25dcff4c41153f1f9413512ba12999b40bf7154d web
- https://github.com/ydb-platform/ydb-go-sdk package
- https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.104.6 web
- https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.134.1 web
- https://github.com/ydb-platform/ydb-go-sdk/releases/tag/v3.134.2 web