Skip to content
OpenAdvisories
Medium · 6.1 GHSA-5f5v-5c3v-gw5v

Silverstripe IE requests not properly behaving with rewritehashlinks

Published May 23, 2024 · Updated Nov 28, 2024 · Assigned by GHSA

Description

Non IE browsers don’t appear to be affected, but I haven’t tested a wide range of browsers to be sure

Requests that come through from IE do NOT appear to encode all entities in the URL string, meaning they are inserted into output content directly by SSViewer::process() when rewriting hashlinks, as it directly outputs $_SERVER[‘REQUEST_URI’]

**Example IE8 request**
127.0.0.1 - - [18/Jun/2014:14:13:42 +1000] “GET /site/cars/brands/toyota?one=1\”onmouseover=\”alert(‘things’);\” HTTP/1.1” 200

**Example FF request**
127.0.0.1 - - [18/Jun/2014:14:14:22 +1000] “GET /site/cars/brands/toyota?one=1\%22onmouseover=\%22alert(%27things%27);\%22 HTTP/1.1” 200

This causes any hash anchor to have the JS code inserted into the page as-is.

Affected packages

EcosystemPackageAffectedFixedRecord
Packagist silverstripe/framework < 3.0.13 3.0.13 GHSA-5f5v-5c3v-gw5v
Packagist silverstripe/framework >= 3.1.0, < 3.1.12 3.1.12 GHSA-5f5v-5c3v-gw5v

References