Skip to content
OpenAdvisories
Low · 3.3 GHSA-hvp5-5x4f-33fq

JADX file override vulnerability

Published Apr 22, 2024 · Updated Dec 5, 2024 · Assigned by GHSA

Description

### Summary
when jadx parses a resource file, there is an escape problem with the style file, which can overwrite other files in the directory when saving the decompile result.

Although I don't think this vulnerability realizes path traversal in the true sense of the word , I reported it anyway

### Details

I see that getResAlias does something with the filename.

```java
private String getResAlias(int resRef, String origKeyName, @Nullable FieldNode constField) {
```

but type style will return the original filename directly.

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232212491.jpeg)
so our goal is to take a malicious file that was originally of type raw, modify its type to style, trick jadx into

#### step1

create an android project using androidstudio and create a raw folder with the name attack_file_sayhiiiiiiiiiiiii, it doesn't matter what the content is!

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232212073.jpg)
generate an initial APK

#### step2

extract this initial APK using ZIP software to get resources.arsc

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232212841.jpg)
drop resources.arsc into 010editor

#### step3

search for the previous filename attack_file_sayhiiiiiiiiiiiii , two will appear here, we choose the second one

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213527.jpg)
let's change the name of the file here. I'll change it to ../../_file_sayhiiiiiiiiiiiii

note that you can only overwrite files in the folder where the decompile was saved.

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213343.jpg)
#### step4
change the type of this file to style

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213183.jpg)
modified to 0E

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213484.jpg)
#### step5

After saving, re-compress the whole folder into a zip, then change the extension to APK.

open it with JADX and you can see that it has been changed to a style type.

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213864.jpg)
click save all

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213119.jpg)
you can see the file escaping.

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213746.jpg)
so we can also construct a

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213497.jpg)
so the classes.dex file is also replaced here

![img](https://quan9i.oss-cn-beijing.aliyuncs.com/img/202401232213075.jpg)

### PoC
the details above have been written

### Impact
latest version

Affected packages

EcosystemPackageAffectedFixedRecord
Maven io.github.skylot:jadx-core < 1.5.0 1.5.0 GHSA-hvp5-5x4f-33fq

References