Skip to content
OpenAdvisories
Medium GHSA-mfjm-vh54-3f96

Scrapy cookie-setting is not restricted based on the public suffix list

Published Mar 1, 2022 · Updated Dec 7, 2024 · Assigned by GHSA

Description

### Impact

Responses from domain names whose public domain name suffix contains 1 or more periods (e.g. responses from `example.co.uk`, given its public domain name suffix is `co.uk`) are able to set cookies that are included in requests to any other domain sharing the same domain name suffix.

### Patches

Upgrade to Scrapy 2.6.0, which restricts cookies with their domain set to any of those in the [public suffix list](https://publicsuffix.org/).

If you are using Scrapy 1.8 or a lower version, and upgrading to Scrapy 2.6.0 is not an option, you may upgrade to Scrapy 1.8.2 instead.

### Workarounds

The only workaround for unpatched versions of Scrapy is to [disable cookies altogether](https://docs.scrapy.org/en/latest/topics/downloader-middleware.html#std-setting-COOKIES_ENABLED), or [limit target domains](https://docs.scrapy.org/en/latest/topics/spiders.html#scrapy.spiders.Spider.allowed_domains) to a subset that does not include domain names with one of the public domain suffixes affected (those with 1 or more periods).

### References
* https://publicsuffix.org/

### For more information

If you have any questions or comments about this advisory:
* [Open an issue](https://github.com/scrapy/scrapy/issues)
* [Email us](mailto:opensource@zyte.com)

Affected packages

EcosystemPackageAffectedFixedRecord
PyPI scrapy < 1.8.2 1.8.2 GHSA-mfjm-vh54-3f96
PyPI scrapy >= 2.0.0, < 2.6.0 2.6.0 GHSA-mfjm-vh54-3f96

References