Skip to content
OpenAdvisories
Medium · 4.3 GHSA-p5h2-vr99-xm99

silverstripe/framework ChangePasswordForm does not check `Member::canLogIn()`

Published May 27, 2024 · Updated Dec 2, 2024 · Assigned by GHSA

Description

After performing a password reset, `ChangePasswordForm::doChangePassword()` logs in the user without checking `Member::canLogIn()`. This presents an issue for sites that are using the extension point in that method to deny access to users (for example members that have not been “approved”, or members that have had their access revoked temporarily). It looks like `Member::canLogIn()` was originally designed to only be used for checking whether the user is locked out (due to too many incorrect login attempts) but has been opened up to other uses.

Affected packages

EcosystemPackageAffectedFixedRecord
Packagist silverstripe/framework >= 3.1.19-rc1, < 3.1.20 3.1.20 GHSA-p5h2-vr99-xm99
Packagist silverstripe/framework >= 3.2.4-rc1, < 3.2.5 3.2.5 GHSA-p5h2-vr99-xm99
Packagist silverstripe/framework >= 3.3.2-rc1, < 3.3.3 3.3.3 GHSA-p5h2-vr99-xm99
Packagist silverstripe/framework >= 3.4.0-rc1, < 3.4.1 3.4.1 GHSA-p5h2-vr99-xm99

References